Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 May 2011 09:35:52 -0700
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        "Andrey V. Elsukov" <bu7cher@yandex.ru>
Cc:        Marcel Moolenaar <marcel@FreeBSD.org>, Warner Losh <imp@FreeBSD.org>, Poul-Henning Kamp <phk@FreeBSD.org>, freebsd-geom@FreeBSD.org
Subject:   Re: [RFC] Remove requirement of alignment to track from MBR scheme
Message-ID:  <D75B2856-D9D8-4BA3-BC54-8258610CEA06@xcllnt.net>
In-Reply-To: <4DDA2F0B.2040203@yandex.ru>
References:  <4DDA2F0B.2040203@yandex.ru>

next in thread | previous in thread | raw e-mail | index | archive | help

On May 23, 2011, at 2:55 AM, Andrey V. Elsukov wrote:

> Hi,
> 
> Since after r221788 many people report about lost of access to their
> MBR partitions, i prepared new patch:
> 	
> 	http://people.freebsd.org/~ae/mbr_geometry.diff
> 
> It removes from GEOM_PART_MBR constraints to alignment to track.
> Now it is possible to create MBR partitions with exactly specified
> start offset and size, and they will not be recalculated by kernel.

Ok, slow down.

While I don't mind that we remove the track alignment when we create
MBR partitions, I don't think we should slap another "big" change on
top of the previous "big" change.

Can I ask we first properly revert the changes we made so far just
so that the revision history clearly states that we cannot enforce
track boundaries. Let's also make sure we have the proper fix for
the "negative partition size" problem that started this whole thing.
And *then* we wait a week, just to be sure we let the dust settle.

I think we've had enough rushed and ill thought-out changes going
in already and I can see that not aligning MBR partitions on a track
boundary is potentially perceived as a PITA violation.

Thanks,

-- 
Marcel Moolenaar
marcel@xcllnt.net





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D75B2856-D9D8-4BA3-BC54-8258610CEA06>