Date: Mon, 5 Apr 2010 17:54:20 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Rui Paulo <rpaulo@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org>, Weongyo Jeong <weongyo@freebsd.org>, Andrew Thompson <thompsa@freebsd.org>, Bernhard Schmidt <bschmidt@techwires.net> Subject: Re: net80211 ratectl proof of concept Message-ID: <E40F1E78-782B-402C-961F-C414849D5F61@freebsd.org> In-Reply-To: <D1EDB040-BB1F-41E2-8E1B-9DEF6171903D@gmail.com> References: <D1EDB040-BB1F-41E2-8E1B-9DEF6171903D@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 Mar 2010, at 14:05, Rui Paulo wrote: > Hi, > I've started developing a ratectl framework for net80211, loosely = based on what DragonFly has. Right now only one driver has been ported, = but I would like your feedback before continuing. >=20 > The objective is to, eventually, have all the ratectl stuff (amrr, = sample, onoe(?) and rssadapt) in net80211 so all drivers can use it. We = can also select which ratectl modules are built in the kernel config = file. > The framework support changing the current ratectl is out of scope for = this patch. >=20 > You can find the patch here: > * http://people.freebsd.org/~rpaulo/ratectl.diff >=20 > Only the ral driver and the AMRR rate control algorithms were ported. >=20 > Some comments: > o The rate control calls now dereferences several pointers and some = inline functions are now real functions. I wonder how much this impacts = performance and what we can do to solve it. >=20 > o I wished there was a better way to do the IEEE80211_AMRR_SUCCESS / = IEEE80211_AMRR_FAILURe call. >=20 > o Some other stuff can also be `const' >=20 > o I create ieee80211_ratect.[ch] to avoid polluting other files >=20 > o I moved the AMRR parameters inside amrr_init() on purpose. The = drivers we have now only specify a different interval and I plan to add = export amrr_set_interval() via the ratectl framework later. >=20 >=20 > I would like very much to see this in, unless there's a strong = impending argument. I've ported all the drivers but I can't test them all. You can read the = patch at the same URL. I would like to commit this soon, though. Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E40F1E78-782B-402C-961F-C414849D5F61>