Date: Wed, 23 Jul 2008 11:30:06 +0000 From: Olafur Osvaldsson <osvaldsson@icelandic.net> To: "Florent Thoumie" <flz@xbsd.org> Cc: ports@freebsd.org, pgollucci@freebsd.org, araujo@freebsd.org Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes Message-ID: <F6E63544-13DD-4464-8EA5-C6D977176A0E@icelandic.net> In-Reply-To: <a01628140807230314r247cd0b2h5da1138ca0a5b67@mail.gmail.com> References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> <a01628140807230314r247cd0b2h5da1138ca0a5b67@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is something the PR responsible introduced in his original patch... On 23.7.2008, at 10:14, Florent Thoumie wrote: > On Tue, Jul 22, 2008 at 11:41 PM, Olafur Osvaldsson > <osvaldsson@icelandic.net> wrote: >> Why has committing a patch gotten so complicated? > > One day since the last update to the PR... The PR responsible recently > got repository privileges so he's probably getting familiar to the > procedures. > > While I'm looking at it, you're checking if NO_INSTALL_MANPAGES which > is wrong. This variable is meant to be set by ports, not users. Even > if it were, you would end up with a incomplete packing list, because > your port installs manual pages unconditionally. I'd suggest getting > rid of the check completely. > > -- > Florent Thoumie > flz@FreeBSD.org > FreeBSD Committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F6E63544-13DD-4464-8EA5-C6D977176A0E>