Date: Wed, 8 Dec 1999 14:53:48 +0900 (JST) From: Michael Hancock <michaelh@cet.co.jp> To: Eivind Eklund <eivind@FreeBSD.ORG> Cc: fs@FreeBSD.ORG Subject: Re: Final call for VOP_ISLOCKED objections Message-ID: <Pine.BSF.3.95LJ1.1b3.991208144549.19997A-100000@sv01.cet.co.jp> In-Reply-To: <19991208014115.L14851@bitbox.follo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Eivind, I think the DEBUG_VFS_LOCKS stuff was temporary debugging infrastructure, put into debug NFS. When SMP gets more fine grained I'm not sure how useful they will be. i.e. race conditions between checking the assertion and the protected code. If the changes to vnode_if.src/vnode_if.sh are just comments then it probably isn't a problem. Regards, Mike On Wed, 8 Dec 1999, Eivind Eklund wrote: > I'd like to commit the changes to VOP_ISLOCKED() I've mentioned here > before. The patches are at > http://www.freebsd/org/~eivind/new-types-for-lock.patch > and > * Make VOP_ISLOCKED() and lockstatus() take an extra parameter > (process), and return a new constant (LK_EXCLOTHER) if the process > parameter is supplied and there is an exclusive lock held by > somebody else. > * Extend the ASSERT_VOP_LOCKED/UNLOCKED family with a series of calls > to do better checking. > * Changes the ASSERT_VOP_UNLOCKED semantics to > unlocked-by-this-process, which is more in line with how the code > use it. > * Introduce new (presently unused) lock descriptions in > vnode_if.src/vnode_if.sh, allowing precise descriptions WRT > shared/exclusive locks. > > They do *not* change any of behaviour unless the undocumented option > DEBUG_VFS_LOCKS is enabled. > > I would like to commit these changes tomorrow, for the convenience > reason of getting an environment I can debug the locking system under, > rushing for getting as much 'stuff' as possible tested and into the > system for the 15th. > > Eivind. > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-fs" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95LJ1.1b3.991208144549.19997A-100000>