Date: Mon, 11 Sep 2000 22:09:29 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Boris Popov <bp@butya.kz> Cc: Doug Rabson <dfr@nlsystems.com>, John Baldwin <jhb@pike.osd.bsdi.com>, Doug Rabson <dfr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h Message-ID: <Pine.BSF.4.21.0009112203560.1112-100000@besplex.bde.org> In-Reply-To: <Pine.BSF.4.10.10009111728410.27558-100000@lion.butya.kz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 11 Sep 2000, Boris Popov wrote: > On Mon, 11 Sep 2000, Bruce Evans wrote: > > > The KTR_EXTEND version of _TR would be reasonable if it used strncpy() > > instead of snprintf(). _CTR0 seems to have an array overruns from using > > memcpy() instead of strncpy(). The portability given by different _CTR > > macros for different numbers of args is defeated by using gcc's variadic > > macro feature in NULLFSDEBUG(). > > I'll replace it with KASSERT-like definition: > > #define NULLFSDEBUG(args) printf args > > with appropriate changes to the rest of the code. I had almost accepted it. Is the only problem with the KASSERT-like definition that double parentheses must be used when it is invoked? This has the same problem as ITR* -- it messes up all invocations of the macros. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0009112203560.1112-100000>