Date: Mon, 10 Jan 2000 23:03:56 +0100 (MET) From: Gerard Roudier <groudier@club-internet.fr> To: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> Cc: Matthew Jacob <mjacob@feral.com>, Peter Wemm <peter@netplex.com.au>, obrien@NUXI.com, "Chris D. Faulhaber" <jedgar@fxp.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf GENERIC LINT Message-ID: <Pine.LNX.3.95.1000110222547.358A-100000@localhost> In-Reply-To: <200001102038.MAA22605@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 10 Jan 2000, Rodney W. Grimes wrote: > .. > > > In either case, NCR needs to be modified so sanity happens. The troub= le is > > > that the nominal owner of NCR, Stefan Esser, doesn't seem to be invol= ved > > > here- otherwise any one of you, David O'Brien, Me, Rodney, whomever, = can > > > just do the right thing. > >=20 > > I feel myself quite involved also in the ncr. The fact that I haven't y= et > > proposed any change for this driver is because I have limited time. > >=20 > > My proposal about ncr/sym coexistence can be illustrated by the followi= ng=20 > > minute diffs (quite untested and incomplete). >=20 > .. > >=20 > > If my proposal gets accepted, I will prepare the corresponding changes. > > I also want to document them in the sym man page I intend to write asap= =20 > > (modulo the time I will have for that). > >=20 > > Could people that are interested in that topic let me know if they agre= e=20 > > or not with my proposal. Thanks. >=20 > This is probably the best solution around. Thanks for your reply and agreement. And it works just fine. I just gave the tiny real changes below a try and= =20 all behaved as expected: Index: sym_hipd.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/dev/sym/sym_hipd.c,v retrieving revision 1.2.2.1 diff -u -r1.2.2.1 sym_hipd.c --- sym_hipd.c=091999/12/30 06:20:08=091.2.2.1 +++ sym_hipd.c=092000/01/10 22:11:06 @@ -128,6 +128,9 @@ #include <dev/sym/sym_conf.h> #include <dev/sym/sym_defs.h> =20 +/* We want to know if the ncr has been configured */ +#include "ncr.h" + /* * On x86 architecture, write buffers management does not=20 * reorder writes to memory. So, preventing compiler from =20 @@ -9649,7 +9652,11 @@ =09struct=09sym_pci_chip *chip; =20 =09chip =3D sym_find_pci_chip(pci_tag); +#if NNCR > 0 +=09if (chip && !(chip->lp_probe_bit & SYM_SETUP_LP_PROBE_MAP)) +#else =09if (chip) +#endif =09=09return chip->name; =09return 0; } This is pretty simple and avoids drivers to know too much about each another. We (I) only must guarantee that both drivers use kind of compatible chip tables which is easy to check and also to maintain given that the chip tables are unlikely to evolve very often and that we have to ensure these tables to be actually fine with the _reality_ of the 53C8XX chip family. If it happens that things ever went wrong, then either bogus or incomplete the chip table of one of the drivers would be. I donnot want to couple the driver sources more than the above patch does for the moment. Btw, under Linux the chip table is defined as a big macro and shared by both the ncr53c8xx and sym53c8xx driver, but both drivers scan the chip table the same way. We can ever also use a single chip table for the ncr and the sym, but it is not urgent and I donnot want to fall into the 'feature of the day' way of developing software that is known to likely broke things rather than fixing them.=20 Thanks again for your reply. G=E9rard. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.3.95.1000110222547.358A-100000>