Date: Thu, 27 Feb 1997 18:21:01 -0500 (EST) From: Chuck Robey <chuckr@glue.umd.edu> To: FreeBSD current <freebsd-current@freefall.FreeBSD.org> Subject: fixing fsck Message-ID: <Pine.OSF.3.95q.970227180615.26998B-100000@uplink.eng.umd.edu>
next in thread | raw e-mail | index | archive | help
I was looking at fsck this morning (I had a few minutes before classes) and I immediately noticed two bugs. One was affecting the ufs mount stuff, where the ufsmount file needed to be included cause of the moved structs in it (ufs/ufs/ufsmount.h), but the other one was slightly more complicated. In dinode.h, all the time related fields, which used to be timespec structs (members tv_sec and tv_usec) are now int32_t, which doesn't have any logical connection to their time-related usage at all. I can't understand the reasoning behind this change. I easily enough made local changes here, changing the called out members, and doing the required casting, so that it would compile, but I haven't checked out all the possible builders of the field, to see if the field, which has changed size from being long X 2 to long X 1, is being correctly built. I can't understand the why behind this modification. If this change (which was done in the name of BSD-Litification, I guess) is going to stay for the sole reason of compatibility with BSD-Lite, I guess I'd continue the debugging, but I cna't see a good reason for this change, and I wonder if it's negotiable. To see what I'm talking about, cd to /sys/sys/ufs/ufs, and do a: cvs diff -r 1.4 dinode.h | less ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@eng.umd.edu | communications topic, C programming, and Unix. 9120 Edmonston Ct #302 | Greenbelt, MD 20770 | I run Journey2 and picnic, both FreeBSD (301) 220-2114 | version 3.0 current -- and great FUN! ----------------------------+-----------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.OSF.3.95q.970227180615.26998B-100000>