Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 05 Jul 2001 12:37:48 -0700 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Matt Jacob <mjacob@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/dev/isp isp_freebsd.c
Message-ID:  <XFMail.010705123748.jhb@FreeBSD.org>
In-Reply-To: <200107051714.f65HEwi80357@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 05-Jul-01 Matt Jacob wrote:
> mjacob      2001/07/05 10:14:57 PDT
> 
>   Modified files:
>     sys/dev/isp          isp_freebsd.c 
>   Log:
>   Things have become cinched down more tightly about assertions for Giant.
>   This uncovered some missing spots where I trade off between isp's lock
>   and Giant as I enter CAM.

I would prefer that you just leave Giant held rather than releasing it until
all the code "under" the unlock/lock pair doesn't need Giant at all.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010705123748.jhb>