Date: Sat, 12 Jan 2002 17:44:56 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <bright@mu.org> Cc: tanimura@freebsd.org, dillon@freebsd.org, smp@freebsd.org Subject: Re: fd locking. Message-ID: <XFMail.020112174456.jhb@FreeBSD.org> In-Reply-To: <20020112173038.H7984@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13-Jan-02 Alfred Perlstein wrote: > * Alfred Perlstein <bright@mu.org> [020112 03:11] wrote: >> I've got world building with these patches. >> >> http://people.freebsd.org/~alfred/fd.diff >> >> or >> >> http://people.freebsd.org/~alfred/fd.diff.gz > > I've been asked for an archetectural overview. One cosmetic tweak: > void fhold(struct file *fp); > /* increments reference count on a file */ > > void fhold_locked(struct file *fp); > /* like fhold but expects file to locked */ Could you change these to return a reference to the fp like crhold()? Thus you end up with code like newfp = fhold(oldfp) which reads better and documents what the old and new references are. It's actually a Terry suggestion. :) Other than that it sounds good. I'm looking over the patch atm and will get back to you if I have any questions. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020112174456.jhb>