Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Jan 2003 15:17:27 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Julian Elischer <julian@elischer.org>
Cc:        "Tim J. Robbins" <tjr@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/kern subr_trap.c
Message-ID:  <XFMail.20030131151727.jhb@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.21.0301311132480.45015-100000@InterJet.elischer.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 31-Jan-2003 Julian Elischer wrote:
> 
> 
> On Fri, 31 Jan 2003, John Baldwin wrote:
> 
>> 
>> On 31-Jan-2003 Julian Elischer wrote:
>> > 
>> > do you know of any other problems?
>> 
>> thread_statclock() has a similar problem as others have noticed:
> 
> what others?
> 
> why doesn't anyone tell ME these things?
> is there some discussion going on in a places I don't see? like IRC?

-----
revision 1.77
date: 2003/01/26 11:41:34;  author: davidxu;  state: Exp;  lines: +646 -513
Move UPCALL related data structure out of kse, introduce a new
data structure called kse_upcall to manage UPCALL. All KSE binding
and loaning code are gone.
...

Reviewed by: julian
-----

Read that last line.  What does that mean to you?  To me it means
that you have looked at the actual diff and approved it.  You didn't
see any bugs in it, etc.  Now, either you didn't look very hard, or
that last line is a lie.  Either way, I want this commit backed out
until such time as it has a 'Reviewed by' line that means something.
It's not enough to just keep fixing the bugs that others find when
they crop up.  Saying that you reviewed something means that you
should be taking responsibility to test things out and really look
at them before they are committed.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030131151727.jhb>