Date: Mon, 14 May 2018 19:40:12 -0400 From: "John W. O'Brien" <john@saltant.com> To: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Practice of "Sponsored by" in commit messages Message-ID: <ae2fe971-b20b-1fdf-48cd-58f595836c11@saltant.com>
next in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CmIm0Q1iMFGRdhu0ETgVSdh76HisTnvTy Content-Type: multipart/mixed; boundary="zk6NYptUzj8eCNuGsVfHp9EbHmbOHWE3W"; protected-headers="v1" From: "John W. O'Brien" <john@saltant.com> To: FreeBSD Ports <freebsd-ports@freebsd.org> Message-ID: <ae2fe971-b20b-1fdf-48cd-58f595836c11@saltant.com> Subject: Practice of "Sponsored by" in commit messages --zk6NYptUzj8eCNuGsVfHp9EbHmbOHWE3W Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hello FreeBSD Ports, The Committer's Guide section on Commit Log Messages [0], doesn't cover the use of the "Sponsored by" key word. As a non-committer contributor, it only recently occurred to me to wonder what work that credit is intended to represent, and whether some light definition would be helpful to reduce ambiguity. When a committer credits a sponsor of theirs, from which the contributor received no sponsorship, the portrayal feels a little awkward. Does this strike the list as a problem, and if so, how ought it be solved? To make this concrete, allow me to illustrate the situation. Alice, working on her own time, prepares and contributes a patch. Bob, who works for Acme Corp, reviews and commits the patch on company time. The commit message includes "Sponsored by: Acme Corp". Alice eagerly awaits her check from Acme Corp. Should the commit message have read "Sponsored by: Acme Corp (Bob)"? This could be extensible to multiple sponsorships. If, instead, Alice prepares the patch having received a grant to do so from Best Sys Dev, the commit message could state "Sponsored by: Acme Corp (Bob), Best Sys Dev (Alice)". [0] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/art= icle.html#commit-log-message PS: I realize that this issue transcends ports, but it's not clear where I should send this instead, and this list seems like it would have a reasonably high concentration of people with a stake in the discussion. --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --zk6NYptUzj8eCNuGsVfHp9EbHmbOHWE3W-- --CmIm0Q1iMFGRdhu0ETgVSdh76HisTnvTy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr6HmEACgkQWPtK56pP /m637wf/RUeAIi/+hcxcRuz4oa6uojwe2A1TAnjnvIplFpb4Ll/EkUvY37/6wjXA nYjTRwoplFC4G6dtbL6ulRx/QIJWBSEWrtXKR2Xi75Dmg2FIXkKxi8qQPqz6p3F/ mwv5qJcDQG+nJrNKqwpY5G+OqkVAhUG6h+/rxv4xslXO0a1Ie2BqAN1QJZhLqVBq h50Jq8RPlKjIQqf5q8GJmuYiVrucUgjKf0IZfUyqi9c5KlHiSULv0H2oYjRWGeKj M8Byj2f8HqyAvTiq5XzI7qcQI3u53ywehkxu++WjlrZOuiiUxaUDwPAXvZ99djcq gBypr1lxh2eR+hZ9+nAGvFG38Mu/yw== =m6Rr -----END PGP SIGNATURE----- --CmIm0Q1iMFGRdhu0ETgVSdh76HisTnvTy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ae2fe971-b20b-1fdf-48cd-58f595836c11>