Date: Tue, 1 Dec 2009 15:25:55 -0800 From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> To: Iain Hibbert <plunky@rya-online.net> Cc: freebsd-bluetooth@freebsd.org Subject: Re: obexapp patches for type-punning Message-ID: <bb4a86c70912011525n56cf9187wfecd230daa3c9d1e@mail.gmail.com> In-Reply-To: <1259695873.086896.28523.nullmailer@galant.ukfsn.org> References: <20091201125054.44a00147@zelz27> <1259694948.961003.27487.nullmailer@galant.ukfsn.org> <1259695873.086896.28523.nullmailer@galant.ukfsn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 1, 2009 at 11:31 AM, Iain Hibbert <plunky@rya-online.net> wrote: > Hi, > > while on the subject of obexapp, I have a patch to remove some annoying > 'type punning' compilation errors that gcc spits out that I'm not totally > sure are valid, but see below anyway.. that is why i had -fno-strict-aliasing in makefile :) > I don't understand the OBEX protocol or libopenobex enough to know if it > is possible, but the last case also removes a potential NULL dereference - > if the OBEX_ObjectGetNonHdrData() fails to recover a proper data, an error > is logged but it carries on and hdr->flags might cause a segfault? yes, i think those are good. combined patch went out in the previous email. thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70912011525n56cf9187wfecd230daa3c9d1e>