Date: 25 Sep 2000 05:24:39 -0700 From: asami@FreeBSD.org (Satoshi - Ports Wraith - Asami) To: Kris Kennaway <kris@FreeBSD.org> Cc: Peter Pentchev <roam@orbitel.bg>, ports@FreeBSD.org Subject: Re: unbreak devel/cdk port, raise minor PORTREVISION issue Message-ID: <vqclmwgslq0.fsf@silvia.hip.berkeley.edu> In-Reply-To: Kris Kennaway's message of "Mon, 25 Sep 2000 03:06:21 -0700 (PDT)" References: <Pine.BSF.4.21.0009250305480.31922-100000@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* From: Kris Kennaway <kris@FreeBSD.org>
* On Mon, 25 Sep 2000, Peter Pentchev wrote:
*
* > Your recent commit to ports/devel/cdk/Makefile breaks builds of the port.
* > Actually, this seems to be a common problem with most ports now that
* > the PORTREVISION/PORTEPOCH system is in place - most ports with bumped
* > PORTREVISION would need an additional (constant) line:
* >
* > WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
*
* The solution would actually be to do this in bsd.port.mk.
No, that is not necessary. I made sure PORTREVISION or PORTEPOCH will
only affect PKGNAME, not DISTNAME (and thus the default WRKSRC).
DISTNAME is supposed to go into ${WRKSRC} by default (and always has,
as long as it existed) and I don't see why we need to change that now.
The real reason of the devel/cdk breakage is the
WRKSRC=${WRKDIR}/${PKGNAME} line in its Makefile. Instead of defining
DISTNAME and WRKSRC, it should have just used DISTFILES. It will
reduce the line count too.
I did a search and this was not the only port that defined WRKSRC as
${WRKDIR}/${PKGNAME}. I committed fixes to all 52 of them just now.
Most of them were the same DISTNAME/WRKSRC[/EXTRACT_SUFX] instead of
DISTFILES mistakes.
Some of the WRKSRC definitions weren't even necessary (as nobody was
changing DISTNAME).
Satoshi
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?vqclmwgslq0.fsf>