Date: 11 Jan 2002 23:40:46 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Alfred Perlstein <bright@mu.org> Cc: Marcel Moolenaar <marcel@xcllnt.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <xzp8zb4h5ox.fsf@flood.ping.uio.no> In-Reply-To: <20020111122534.K7984@elvis.mu.org> References: <200201100536.g0A5aao01807@freefall.freebsd.org> <xzpy9j5hecf.fsf@flood.ping.uio.no> <20020110191209.A318@dhcp01.pn.xcllnt.net> <xzpu1tth859.fsf@flood.ping.uio.no> <20020110203918.A440@dhcp01.pn.xcllnt.net> <xzppu4hgkwg.fsf@flood.ping.uio.no> <20020111112851.A2103@kayak.xcllnt.net> <xzpd70ghc78.fsf@flood.ping.uio.no> <20020111122534.K7984@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein <bright@mu.org> writes: > * Dag-Erling Smorgrav <des@ofug.org> [020111 12:20] wrote: > > Since when does "talking it over first" mean "commit a patch without > > discussing it with the person who wrote the code it changes"? > > Especially when similar patches have been suggested, discussed, and > > rejected before (see for instance the audit trail for PR 26546). > You don't give a reason for your: > "Partial fix committed, more work remains to be done." See the log entry for revision 1.68 of linux_ioctl.c, and succeeding revisions. > This should have included _why_ you didn't incorperate the > diffs instead of just stating that you didn't. I *did* incorporate the diffs in the PR, with modifications, but they did not fully solve the problem - they were just a hack to get the aironet config utility working. I busted my ass for two weeks, working literally night and day, to get interface ioctls to work under Linux emulation - not just the three or four ioctls the patch in the PR fixes, but as many as I could actually test with the hardware and software I have, to the point where a Linux ifconfig(8) binary can now correctly list all interfaces, their Ethernet and IP addresses, and all the interface flags for which I could find a meaningful counterpart in Linux. The sparse interface numbering is a cosmetic nit, which I did not consider important enough to warrant the pain of fixing it properly. It apparently trips up at least two Linux applications, but nobody bothered to submit a PR about it, so I've never had the chance to actually analyze the problem. > It would make both the PR originator as well as fellow developers > understand why and how you are doing things. Both ambrisko (who submitted the PR) and marcel were involved in the development of the patches I *did* commit. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp8zb4h5ox.fsf>