Skip site navigation (1)Skip section navigation (2)
Date:      11 Jan 2002 04:35:30 +0100
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        Marcel Moolenaar <marcel@xcllnt.net>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/compat/linux linux_ioctl.c
Message-ID:  <xzpu1tth859.fsf@flood.ping.uio.no>
In-Reply-To: <20020110191209.A318@dhcp01.pn.xcllnt.net>
References:  <200201100536.g0A5aao01807@freefall.freebsd.org> <xzpy9j5hecf.fsf@flood.ping.uio.no> <20020110191209.A318@dhcp01.pn.xcllnt.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar <marcel@xcllnt.net> writes:
> It is correct WRT the translations done the opposite direction. If
> this is incorrect, the other fixes are also incorrect. Either they
> both go, or they all stay. Since you didn't object to the first
> round of fixes, I don't see how you can object to this one.

I would have if I had noticed them, but I was too busy at the time.  I
have already provided reasons why both sets of changes are incorrect.

So please back revisions 1.77 and 1.79 out.

> Thirdly, you did not consult me when you made the changes, as I was
> at that time the official *active* maintainer of the Linuxulator.

Yes, I did.  You reviewed my patch.  Do you want a copy of my mail
archive?

> So, all considered, I urge you to be constructive and provide good
> explanations as to why you think it is broken and I'm sure we can
> sort it all out. In the mean time the only conclusive evidence I
> have is that it fixes a bug. I have yet to see a report that it
> breaks something else.

1) This numbering scheme allows interfaces to move.

2) Your commit breaks linprocfs.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpu1tth859.fsf>