Date: Sun, 8 Jun 2003 02:13:54 -0500 From: Juli Mallett <jmallett@FreeBSD.org> To: Greg Lehey <grog@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/asf Makefile asf.c Message-ID: <20030608021354.A40746@FreeBSD.org> In-Reply-To: <200306080618.h586ID4a026484@repoman.freebsd.org>; from grog@FreeBSD.org on Sat, Jun 07, 2003 at 11:18:13PM -0700 References: <200306080618.h586ID4a026484@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Greg Lehey <grog@FreeBSD.org> [ Date: 2003-06-08 ] [ w.r.t. cvs commit: src/usr.sbin/asf Makefile asf.c ] > grog 2003/06/07 23:18:13 PDT > > FreeBSD src repository > > Added files: > usr.sbin/asf Makefile asf.c > Log: > Introducing asf, a helper program for kernel debugging. This looks pretty messy and doesn't even have a license on it. Will it be tied to the build? Any reason it doesn't use the getopt(3) function, or in any way look like the normal BSD style for utilities? Please use a paths.h instead of the evilly hardcoded program paths. If this won't be tied up to the build it should probably be in src/tools, and I'd argue it should be there anyway. Thanx, juli. -- juli mallett. email: jmallett@freebsd.org; efnet: juli;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030608021354.A40746>