Date: Tue, 07 Jun 2016 04:15:11 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 209675] graphics/inkscape: Fix build with libc++ 3.8.0 Message-ID: <bug-209675-6497-ZGLksWten4@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209675-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-209675-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209675 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: truckman Date: Tue Jun 7 04:14:38 UTC 2016 New revision: 416493 URL: https://svnweb.freebsd.org/changeset/ports/416493 Log: Fix type for abs() calls in graphics/inkscape During the exp-run in bug 208158, it was found that graphics/inkscape gives errors with libc++ 3.8.0: libavoid/connector.cpp:888:29: error: call to 'abs' is ambiguous COLA_ASSERT(abs(i->pathNext->id.objID - i->id.objID) !=3D= 2); ^~~ This is because abs() is called with unsigned arguments. Fix it by casting the arguments to the appropriate signed types. This mimics what happens with older libraries where the only version of abs() was the one in <stdlib.h>, which is prototyped: int abs(int) The expression used in ConnRef::generatePath() is not strictly correct because it depends on details of integer overflow that are undefined by the C++ standard. PR: 209675 Submitted by: dim Changes: head/graphics/inkscape/files/ head/graphics/inkscape/files/patch-src_libavoid_connector.cpp head/graphics/inkscape/files/patch-src_ui_tools_flood-tool.cpp --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209675-6497-ZGLksWten4>