Date: Mon, 9 Jan 2006 21:19:05 +0100 From: "Andreas Kohn" <andreas@syndrom23.de> To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org> Subject: ports/91566: [MAINTAINER-UPDATE] x11-wm/transset-df: fix build on 4.x, USE_GETOPT_LONG Message-ID: <1136837945.1687@klamath.syndrom23.de> Resent-Message-ID: <200601092020.k09KK3QU034758@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 91566
>Category: ports
>Synopsis: [MAINTAINER-UPDATE] x11-wm/transset-df: fix build on 4.x, USE_GETOPT_LONG
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Mon Jan 09 20:20:03 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Andreas Kohn
>Release: FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD 7.0-CURRENT #21: Mon Jan 2 22:03:29 CET 2006
root@klamath.syndrom23.de:/usr/obj/usr/src/sys/KLAMATH
>Description:
Daniel <daniel@netwalk.org> reported that transset-df doesn't build
on his FreeBSD 4.x system, and the error message points to getopt().
I have no 4.x system, but I assume that adding USE_GETOPT_LONG should fix the build in this case.
Also for 4.x, move some variable declaration up, to please gcc 2.95.
>How-To-Repeat:
Try to compile transset-df on 4.x/with gcc 2.95
>Fix:
--- transset-df-4.x.diff begins here ---
Index: files/patch-transSet.c
===================================================================
--- files/patch-transSet.c (revision 0)
+++ files/patch-transSet.c (revision 505)
@@ -0,0 +1,27 @@
+--- transSet.c.orig Mon Jan 9 21:09:08 2006
++++ transSet.c Mon Jan 9 21:10:27 2006
+@@ -121,6 +121,11 @@
+ {"verbose",0,NULL,'v'},
+ {0,0,0,0}
+ };
++ unsigned char *data;
++
++ Atom actual;
++ int format;
++ unsigned long n, left;
+
+ /* wonderful utility */
+ Setup_Display_And_Screen(&argc, argv);
+@@ -228,12 +233,6 @@
+ target_win = Select_Window(dpy);
+ }
+
+- unsigned char *data;
+-
+- Atom actual;
+- int format;
+- unsigned long n, left;
+-
+ if (!gotd) d=0.75;
+
+ /* get property */
Index: Makefile
===================================================================
--- Makefile (revision 503)
+++ Makefile (revision 505)
@@ -16,6 +16,7 @@
USE_X_PREFIX= yes
ALL_TARGET= transset-df
MAKE_ARGS= CFLAGS="${CFLAGS}"
+USE_GETOPT_LONG=yes
PLIST_FILES= bin/transset-df
--- transset-df-4.x.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1136837945.1687>