Date: Sun, 28 Oct 2001 09:42:24 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Greg Lehey <grog@FreeBSD.org> Cc: mjacob@feral.com, Jonathan Lemon <jlemon@flugsvamp.com>, "Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) Message-ID: <31874.1004258544@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 28 Oct 2001 19:02:25 %2B1030." <20011028190225.A88146@monorchid.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011028190225.A88146@monorchid.lemis.com>, Greg Lehey writes: >On Sunday, 28 October 2001 at 9:28:44 +0100, Poul-Henning Kamp wrote: >> In message <20011028085000.O8085@wantadilla.lemis.com>, Greg Lehey writes: >> >>> I can't be bothered looking for a rule that says you shouldn't commit >>> anything which will knowingly cause breakage, but if it's not in the >>> book, it should be. First ensure that cause of the breakage gets >>> fixed, or fix it yourself. >> >> The kernel itself has been whining at making this mistake since >> 11 sep 2000. >> >> That should be more than sufficient warning for anyone. > >So why haven't you fixed it? Because it is not my task to fix all broken drivers. The message is "WARNING: driver mistake ..." for a very good reason. For instance, I can see the bogus code (mentioned earlier) in asr.c but since I have no hardware I cannot test my hypothesis that the entire driverinit function can be removed. >Seriously, though, you've got to admit that's rather irrelevant to the >statement. Huh ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31874.1004258544>