Date: Tue, 12 Feb 2008 22:50:03 GMT From: Sean Bruno <sbruno@miralink.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/120569: [bge] [patch] Update dev id's for bge Message-ID: <200802122250.m1CMo3i5085794@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/120569; it has been noted by GNATS.
From: Sean Bruno <sbruno@miralink.com>
To: bug-followup@FreeBSD.org, sbruno@miralink.com
Cc:
Subject: Re: kern/120569: [bge] [patch] Update dev id's for bge
Date: Tue, 12 Feb 2008 14:18:55 -0800
This is a multi-part message in MIME format.
--------------030009000500040406010701
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
I forgot to include this change for mii_physubr.c
Apparently this adapter reports ife->ifm_data as == MII_NMEDIA
Not sure if that is a bug or how it should be, but this is required
along with the previous patch.
Sean
--------------030009000500040406010701
Content-Type: text/x-patch;
name="mii.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="mii.diff"
Index: /branches/miralink.FreeBSD.6/src/sys/dev/mii/mii_physubr.c
===================================================================
--- /branches/miralink.FreeBSD.6/src/sys/dev/mii/mii_physubr.c (revision 3333)
+++ /branches/miralink.FreeBSD.6/src/sys/dev/mii/mii_physubr.c (revision 5102)
@@ -121,11 +121,11 @@
/*
* Table index is stored in the media entry.
*/
- KASSERT(ife->ifm_data >=0 && ife->ifm_data < MII_NMEDIA,
+ KASSERT(ife->ifm_data >=0 && ife->ifm_data <= MII_NMEDIA,
("invalid ife->ifm_data (0x%x) in mii_phy_setmedia",
ife->ifm_data));
anar = mii_media_table[ife->ifm_data].mm_anar;
bmcr = mii_media_table[ife->ifm_data].mm_bmcr;
--------------030009000500040406010701--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802122250.m1CMo3i5085794>