Date: Fri, 08 Sep 2006 10:49:46 +0200 From: Andre Oppermann <andre@freebsd.org> To: Andrew Thompson <thompsa@freebsd.org> Cc: freebsd-net@freebsd.org, yar@comp.chem.msu.su, freebsd-arch@freebsd.org Subject: Re: Moving ethernet VLAN tags into the mbuf packet header (from mtags) Message-ID: <45012EAA.4010303@freebsd.org> In-Reply-To: <20060908010835.GA6334@heff.fud.org.nz> References: <450035AD.3040600@freebsd.org> <20060908010835.GA6334@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Thompson wrote: > On Thu, Sep 07, 2006 at 05:07:25PM +0200, Andre Oppermann wrote: >> With the recent addition of a 16bit field for TSO into the mbuf packet >> header we've got 16bits left over. I've reserved these bits for the >> ethernet VLAN tagging of packet to do away with the allocated mbuf mtag. >> >> The change is rather mechanical. Patch available here: >> >> http://people.freebsd.org/~andre/vlan_pkthdr-20060907.diff >> > > RCS file: /home/ncvs/src/sys/netgraph/ng_vlan.c,v > retrieving revision 1.3 > diff -u -p -r1.3 ng_vlan.c > --- netgraph/ng_vlan.c 20 Apr 2005 14:19:20 -0000 1.3 > +++ netgraph/ng_vlan.c 7 Sep 2006 15:03:58 -0000 > > <...> > > - vlan = EVL_VLANOFTAG(VLAN_TAG_VALUE(mtag)); > + vlan = m->m_pkthdr.ether_vlan; > (void)&evl; /* XXX silence GCC */ > > I think this is a typeo, EVL_VLANOFTAG is still needed. I like the > change and it helps out a few related projects that people are working > on. Fixed. Thanks for the review! -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45012EAA.4010303>