Date: Sat, 12 Apr 2003 21:01:12 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c Message-ID: <25540.1050174072@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 12 Apr 2003 10:25:49 PDT." <Pine.BSF.4.21.0304121013010.38364-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.21.0304121013010.38364-100000@root.org>, Nate Lawson wri tes: >Uh, tell me who is going to call cam_periph_ioctl()? This is necessary >to allow camcontrol to get a passthrough device. All the other drivers >call it. > >What bothers me is that you don't pay attention to MAINTAINERS: >>CAM gibbs, >> ken Pre-commit review requested. send to scsi@freebsd.org > >I don't think you'd be happy if I picked a random, seemingly unused >function in geom and nuked it, apparently without understanding the >impact. Please be considerate of others. > >-Nate I'd appreciate you check your facts before you attack people in the future. While attacking on unproven assumptions is all the rage these days it is still rather embarrasing when people point out that you are wrong in all aspects of your attack: The ioctl function in scsi_da is not called, libcam opens /dev/xpt and uses an ioctl there to find the correct pass device. The call path to the function has been disabled for a period with not a single complaint that I have been able to discover. Second, I have discussed this particular change with ken@, who as you correctly point out is the maintainer, and he agreed that the function was unused. So I really don't know why or what compelled you to attack me here, whatever it was: please try to control it better in the future. Over and out... Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25540.1050174072>