Date: Thu, 27 Nov 2008 15:52:44 +0100 From: "Paul B. Mahol" <onemda@gmail.com> To: freebsd-bugs@freebsd.org Subject: Re: kern/127411: [ata] [panic] ata panics on bad block Message-ID: <3a142e750811270652i6fbfaab9wd708148d7507c1ec@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Fixed by following change: Date: Thu Nov 27 03:37:46 2008 New Revision: 185357 URL: http://svn.freebsd.org/changeset/base/185357 Log: Don't let ata_completed() dereference a null request->dma pointer to print dma status after a media error. Modified: h @@ -357,7 +357,7 @@ ata_completed(void *context, int dummy) "\6MEDIA_CHANGED\5NID_NOT_FOUND" "\4MEDIA_CHANGE_REQEST" "\3ABORTED\2NO_MEDIA\1ILLEGAL_LENGTH"); - if ((request->flags & ATA_R_DMA) && + if ((request->flags & ATA_R_DMA) && request->dma && (request->dma->status & ATA_BMSTAT_ERROR)) printf(" dma=0x%02x", request->dma->status); if (!(request->flags & (ATA_R_ATAPI | ATA_R_CONTROL))) -- Paul
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a142e750811270652i6fbfaab9wd708148d7507c1ec>