Date: Mon, 18 Dec 2000 09:41:10 -0800 (PST) From: John Baldwin <jhb@FreeBSD.ORG> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: current@FreeBSD.ORG Subject: Re: test/review: /dev/console logging patch Message-ID: <XFMail.001218094110.jhb@FreeBSD.org> In-Reply-To: <25651.977121415@critter>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18-Dec-00 Poul-Henning Kamp wrote: > In message <XFMail.001217150456.jhb@FreeBSD.org>, John Baldwin writes: >> >>On 17-Dec-00 Poul-Henning Kamp wrote: >>> >>> This patch is for the printf(9), log(9) & /dev/console stuff. >>> The result is that you can watch the output from /etc/rc in >>> your /var/log/messages. >>> >>> Poul-Henning >>> >>> >>> 1. Replace logwakeup() with msgbuftrigger++; There is little >>> point in calling a function to set a flag. >> >>Abstraction to keep other code from having to know the iternals of the log(9) >>device? Maybe use a #define for logwakeup() that does the msgbuftrigger++ to >>keep the abstraction w/o the overhead? > > But it was actually the other way around now :-) It was the log > device which had obfuscated the log/printf code because it needed > it's assistance to call selwakeup. > > I want the log/printf code to be as simple as possible, and to have > the smallest stack footprint possible... Ok, works for me. :) -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001218094110.jhb>