Date: Mon, 3 Feb 2014 11:15:42 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, theraven@FreeBSD.org, ports-committers@freebsd.org Subject: Re: svn commit: r341510 - head/lang/libobjc2 Message-ID: <20140203111542.426f69be@kalimero.tijl.coosemans.org> In-Reply-To: <201401280813.s0S8DcHf067201@svn.freebsd.org> References: <201401280813.s0S8DcHf067201@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 Jan 2014 08:13:38 +0000 (UTC) Baptiste Daroussin wrote: > Author: bapt > Date: Tue Jan 28 08:13:37 2014 > New Revision: 341510 > URL: http://svnweb.freebsd.org/changeset/ports/341510 > QAT: https://qat.redports.org/buildarchive/r341510/ > > Log: > Support stage > Respect prefix > > Modified: > head/lang/libobjc2/Makefile > > Modified: head/lang/libobjc2/Makefile > ============================================================================== > --- head/lang/libobjc2/Makefile Tue Jan 28 08:04:07 2014 (r341509) > +++ head/lang/libobjc2/Makefile Tue Jan 28 08:13:37 2014 (r341510) > @@ -12,10 +12,10 @@ COMMENT= Replacement Objective-C runtime > > SSP_UNSAFE= yes > > -NO_STAGE= yes > -.include <bsd.port.options.mk> > - > USES= cmake > +BROKEN_powerpc= Does not compile on powerpc: Unsupported relocation type 10 > + > +.include <bsd.port.options.mk> > > _CLANG!= if [ -f /usr/bin/clang ] ; then /usr/bin/clang --version | head -1 | \ > ${SED} -e 's/.*clang version \([0-9]\)\.\([0-9]\).*/\1\2/' ; else ${ECHO} 0 ; fi > @@ -42,8 +42,6 @@ PLIST_SUB+= WITH_SEPARATECXX="" > PLIST_SUB+= WITH_SEPARATECXX="@comment " > .endif > > -.include <bsd.port.pre.mk> > - > CMAKE_ARGS+= -DLIB_INSTALL_PATH=lib -DCMAKE_ASM_COMPILER=${CLANG} > CMAKE_ARGS+= -DCMAKE_C_COMPILER=${CLANG} -DCMAKE_CXX_COMPILER=${CLANGXX} > CMAKE_ARGS+= -DTESTS=OFF The port is currently broken. By removing the bsd.port.pre.mk include -DCMAKE_C_COMPILER:STRING="${CC}" in Uses/cmake.mk now comes after the -DCMAKE_C_COMPILER=${CLANG} here so it doesn't have any effect. Same for CXX. Instead of putting .include <bsd.port.pre.mk> back, maybe the port should define CC=${CLANG} CXX=${CLANGXX} and remove the second CMAKE_ARGS line?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140203111542.426f69be>