Date: Sat, 9 Feb 2008 09:35:47 GMT From: John Birrell <jb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 135099 for review Message-ID: <200802090935.m199Zlil095505@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=135099 Change 135099 by jb@jb_freebsd1 on 2008/02/09 09:34:53 In the great tradition of the undocumented clone_create() interface, if you pass a pointer to an uninitialised variable, you can get a panic "foo". Yes, "foo". This didn't happen on amd64, but it seems to happen all the time on i386. A closer inspection of the code in sys/kern/kern_conf.c shows that the variable should have been set to -1. Sigh. Affected files ... .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_clone.c#9 edit Differences ... ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_clone.c#9 (text+ko) ==== @@ -32,7 +32,7 @@ static void dtrace_clone(void *arg, struct ucred *cred, char *name, int namelen, struct cdev **dev) { - int u; + int u = -1; size_t len; if (*dev != NULL)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802090935.m199Zlil095505>