Date: Mon, 31 May 2010 20:57:15 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: gnome@freebsd.org Subject: Re: ports/146885: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set Message-ID: <AANLkTikPbDUfD_CqiJiEdy3Axwiy-YyqSL8Dv1sk2mEz@mail.gmail.com> In-Reply-To: <4C047CF9.6080409@freebsd.org> References: <201005312120.o4VLKJMi078305@freefall.freebsd.org> <AANLkTilwwwTgipFMq1atDFmuROKkeb4JyR5ZvnEVQlR_@mail.gmail.com> <4C0452D8.9000408@freebsd.org> <AANLkTimOZQ_ogVEGcx3YFH-VWSQ9OTyy0yWNJ8Q8rMZZ@mail.gmail.com> <4C047CF9.6080409@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 31, 2010 at 8:22 PM, Joe Marcus Clarke <marcus@freebsd.org> wro=
te:
> On 5/31/10 10:47 PM, Garrett Cooper wrote:
>> On Mon, May 31, 2010 at 5:22 PM, Joe Marcus Clarke <marcus@freebsd.org> =
wrote:
>>> On 5/31/10 7:45 PM, Garrett Cooper wrote:
>>>> On Mon, May 31, 2010 at 2:20 PM, =A0<marcus@freebsd.org> wrote:
>>>>> Synopsis: [patch] fix make package for x11-toolkits/gtk20 when WITHOU=
T_CUPS set
>>>>>
>>>>> State-Changed-From-To: open->feedback
>>>>> State-Changed-By: marcus
>>>>> State-Changed-When: Mon May 31 21:17:12 UTC 2010
>>>>> State-Changed-Why:
>>>>> I don't see the bug. =A0First, we _should_ be checking for libcups in=
${LOCALBASE}
>>>>> and not ${PREFIX}. =A0The other changes just look to be aesthetic.
>>>>
>>>> =A0 =A0 They're not. :=3D is acceptable for deferred make variables...=
not
>>>> for the plist stuff (was this ever functional?).
>>>
>>> Yes, that's functional and perfectly allowed. =A0The ":=3D" in this not=
ation
>>> is just acting as a label (the label being "CUPS:"). =A0There are other
>>> ports which use this same notation.
>>
>> Why does my version pass then when cups isn't installed :)?
>> Thanks,
>> -Garrett
>>
>>
>
> I don't see a bug, and this code hasn't changed in sometime. =A0To be
> clear you do NOT have /usr/local/lib/libcups.so installed? =A0Exactly wha=
t
> CUPS-related macros do you have defined?
I haven't willingly defined any CUPS related macros. The only ones
that have been defined in the past (because they were the defaults and
I hadn't cleaned them out until as of late) were the CUPS knobs in
print/ghostscript8-nox11. There also appear to be a bunch of implicit
dependencies on cups in xfce4 dependencies for some odd reason even
though I purposely have USE_PRINT unchecked. I pkg_delete'd
cups-client and cups-image today and I'm yanking out the rest of the
bits by hand while I'm upgrading xfce4 today.
Running make package doesn't yield the same problem it did before, but
I purposely yanked all of the cups packages.
Looking for the files in ${LOCALBASE}, not ${PREFIX} seems
non-portable if ports wants to make an attempt at the case where
${PREFIX} !=3D ${LOCALBASE} though.
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikPbDUfD_CqiJiEdy3Axwiy-YyqSL8Dv1sk2mEz>