Date: Thu, 23 Jan 2003 02:00:18 -0800 (PST) From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/47390: Updated Port: security/fakeident Message-ID: <200301231000.h0NA0IkE020512@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47390; it has been noted by GNATS.
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Dean Hollister <dean@odyssey.apana.org.au>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 10:56:42 +0100
--=.QSucp1gThSKh+Q
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Dean Hollister told:
> diff -ruN fakeident.old/Makefile fakeident/Makefile
[...]
> do-install:
> - $(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
> - $(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
> + $(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(LOCALBASE)/sbin
> + $(INSTALL) -m 755 -o root -g wheel $(FILESDIR)/fakeident.sh $(LOCALBASE)/etc/rc.d
are you sure about this? seems like making this not PREFIX clean.
better use:
${INSTALL_PROGRAM} ${WRKSRC}/identd ${PREFIX}/sbin
${INSTALL_SCRIPT} ${FILESDIR}/fakeident.sh ${PREFIX}/etc/rc.d
> diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
[...]
> +stop)
> + kill -9 `cat /var/run/identd.pid` && echo -n ' fakeidentd'
> + ;;
how about checking for /var/run/identd.pid existance?
otherwise stopping a not running fakeidentd will produce an ugly error
message:
cat: /var/run/identd.pid: No such file or directory
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--=.QSucp1gThSKh+Q
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+L7xar5S+dk6z85oRAgYnAJ91cNkfJDrxoALVjUVfn7bQRUIdiwCgzrty
+ecUM3KGHtw5HGFIoTpVx2Y=
=rWzl
-----END PGP SIGNATURE-----
--=.QSucp1gThSKh+Q--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301231000.h0NA0IkE020512>