Date: Mon, 27 Jan 2014 15:12:26 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r341406 - head/devel/bncsutil-ghost++ Message-ID: <20140127141225.GA33006@ithaqua.etoilebsd.net> In-Reply-To: <20140127140836.GB68244@FreeBSD.org> References: <201401271337.s0RDbvuO022647@svn.freebsd.org> <20140127140836.GB68244@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2014 at 02:08:36PM +0000, Alexey Dokuchaev wrote: > On Mon, Jan 27, 2014 at 01:37:57PM +0000, Baptiste Daroussin wrote: > > New Revision: 341406 > > URL: http://svnweb.freebsd.org/changeset/ports/341406 > > QAT: https://qat.redports.org/buildarchive/r341406/ > >=20 > > +MAKE_ARGS=3D PREFIX=3D${STAGEDIR}${PREFIX} >=20 > It would be nice (per our previous discussion) to briefly summarize in the > commit log why, in the particular case, such construct is safe, as genera= lly > is is not. >=20 > ./danfe Right in that case I check that PREFIX is only used during the install phas= e (in the upstream build process) I also checked that the install process wasn't = going to hardcode PREFIX somewhere. I run stage-qa and verified if nothing yelled at me :) With both checks I knew that it was safe to cheat on the prefix to install directly on stagedir. regards, Bapt --envbJBWh7q8WU6mo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLmaUkACgkQ8kTtMUmk6EyYuACeI8psfpVY/dsU60ViY8pUc8yF lSUAniYYv8Xh7zGNgVT1LL0M1+9kto/u =I3AY -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140127141225.GA33006>