Date: Mon, 27 Jan 2014 15:24:52 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r341406 - head/devel/bncsutil-ghost++ Message-ID: <20140127142451.GB33006@ithaqua.etoilebsd.net> In-Reply-To: <20140127142052.GA71123@FreeBSD.org> References: <201401271337.s0RDbvuO022647@svn.freebsd.org> <20140127140836.GB68244@FreeBSD.org> <20140127141225.GA33006@ithaqua.etoilebsd.net> <20140127142052.GA71123@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--UHN/qo2QbUvPLonB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2014 at 02:20:52PM +0000, Alexey Dokuchaev wrote: > On Mon, Jan 27, 2014 at 03:12:26PM +0100, Baptiste Daroussin wrote: > > On Mon, Jan 27, 2014 at 02:08:36PM +0000, Alexey Dokuchaev wrote: > > > On Mon, Jan 27, 2014 at 01:37:57PM +0000, Baptiste Daroussin wrote: > > > > New Revision: 341406 > > > > URL: http://svnweb.freebsd.org/changeset/ports/341406 > > > > QAT: https://qat.redports.org/buildarchive/r341406/ > > > >=20 > > > > +MAKE_ARGS=3D PREFIX=3D${STAGEDIR}${PREFIX} > > >=20 > > > It would be nice (per our previous discussion) to briefly summarize in > > > the commit log why, in the particular case, such construct is safe, as > > > generally is is not. > >=20 > > Right; in that case I check that PREFIX is only used during the install > > phase (in the upstream build process) I also checked that the install > > process wasn't going to hardcode PREFIX somewhere. [...] >=20 > Baptiste, I know that you, as overall accurate committer, had done all > the checking required to ensure that this construct, in this particular > case is OK. My point is that it better be briefly reflected in the log, > as other, less careful or experienced folks might see it as "Oh, OK, I > can simply set prefix to ${STAGEDIR}/${PREFIX} and be cone with it." >=20 Right, I'll do next time:) regards, Bapt --UHN/qo2QbUvPLonB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLmbDMACgkQ8kTtMUmk6Ext/wCfVLbQFH9vbVEPGIbDbqLYUjKP KYUAn2nF71XIbDasJk4ayfWcJmk6ijjY =p4o0 -----END PGP SIGNATURE----- --UHN/qo2QbUvPLonB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140127142451.GB33006>