Date: Mon, 14 Oct 2002 09:10:04 +0200 (CEST) From: Harti Brandt <brandt@fokus.gmd.de> To: Luigi Rizzo <rizzo@icir.org> Cc: "M. Warner Losh" <imp@bsdimp.com>, <net@FreeBSD.ORG> Subject: Re: Comments Please Message-ID: <20021014090528.V19145-100000@beagle.fokus.gmd.de> In-Reply-To: <20021012191709.B93684@carp.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 12 Oct 2002, Luigi Rizzo wrote:
LR>On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote:
LR>...
LR>> : reveals the use of an explicit constant (6) in net/if_arp.h and
LR>> : netinet/if_ether.c; there is more of the same in net/bridge.c
LR>> : (my fault), net/if_atmsubr.c, netinet/if_ether.c, netncp/ncp_subr.c
LR>>
LR>> atmsubr? Doesn't ATM have its own constants?
LR>
LR>eh, that's the problem with explicit constants, you can never tell
LR>whether "6" is english, german or italian... in any case the
LR>relevant piece of code is:
LR>
LR> net/if_atmsubr.c: if (bcmp(alc, ATMLLC_HDR, 6)) {
LR>
LR>I have no idea if it has any relation with ethernet header sizes.
No, this is the length of an LLC/SNAP header minus the type field.
harti
--
harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private
brandt@fokus.gmd.de, brandt@fokus.fhg.de
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021014090528.V19145-100000>