Date: Mon, 23 Apr 2001 20:01:52 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Greg Lehey <grog@lemis.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_bmap.c cd9660_lookup.c cd9660_node.c cd9660_rrip.c cd9660_util.c cd9660_vfsops.c cd9660_vnops.c Message-ID: <Pine.BSF.4.21.0104231939150.4878-100000@besplex.bde.org> In-Reply-To: <20010423190023.D37321@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Apr 2001, Greg Lehey wrote: > On Monday, 23 April 2001 at 19:25:09 +1000, Bruce Evans wrote: > > On Mon, 23 Apr 2001, Greg Lehey wrote: > >> Well, it doesn't exactly seem to be correct to redefine AF_MAX in > >> sys/mount.h to get around it. But pass me the pointy hat: I checked > >> with make world and forgot LINT. > > > > Defining AF_MAX in 2 places is easier than having a whole header just for > > defining AF_MAX. The definitions won't get out of sync, because building > > kernels will give warnings about them being different, and committed code > > doesn't cause warnings ;-). > > > > The include of <net/radix.h> is unrelated to this. <net/radix.h> is already > > ... > > Good analysis. You didn't answer the second part of my message: > > > So what would you suggest? Erm, just put things back like they used to be? :-) > At the moment, GENERIC builds. LINT doesn't. I have the fixes to > LINT ready to commit, but there's not much point if you think I should > back all the crap out. I don't think <net/radix.h> and <sys/socket.h> should be prerequisites for <sys/mount.h>, especially new ones. So please back it all out. The netcred and netexport stuff may belong in a separate header. struct netexport doesn't seem to used outside of vfs_subr.c, and moving its declaration there would eliminate AF_MAX from <sys/mount.h>. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0104231939150.4878-100000>