Date: Thu, 30 May 2002 02:09:44 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Tony Finch <dot@dotat.at> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys gpt.h Message-ID: <20020530090944.GB8405@dhcp01.pn.xcllnt.net> In-Reply-To: <20020530094039.B10098@chiark.greenend.org.uk> References: <200205300544.g4U5iN586002@freefall.freebsd.org> <20020530094039.B10098@chiark.greenend.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 30, 2002 at 09:40:39AM +0100, Tony Finch wrote: > On Wed, May 29, 2002 at 10:44:23PM -0700, Marcel Moolenaar wrote: > > > > o Remove GCC specific attribute packed. > > o Add incomplete array padding. > > Note that the padding array you have added doesn't cover the padding in > the struct that you are having trouble with: offsetof(struct gpt_hdr, > padding) == sizeof(struct gpt_hdr), i.e. there are 4 bytes of padding > before the incomplete array member. I checked with GCC and offsetof != sizeof. > It's also a gratuitous C99ism -- a comment would be better. I need to solve a problem, so there's nothing gratuitous about it. BTW: I think it's time you give it a rest. Your remarks just about now stopped being constructive. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020530090944.GB8405>