Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Oct 2001 12:49:29 -0400 (EDT)
From:      Mikhail Teterin <mi@aldan.algebra.com>
To:        roam@FreeBSD.org
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: ports/graphics/gd Makefile pkg-plist
Message-ID:  <200110261649.f9QGnWa79416@aldan.algebra.com>
In-Reply-To: <200110261207.f9QC72K56756@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Oct, Peter Pentchev wrote:
> roam        2001/10/26 05:07:02 PDT
> 
>   Modified files:
>     graphics/gd          Makefile pkg-plist 
>   Log:
>   Install the HTML documentation.

I think
	.if !defined(NOPORTDOCS)
	post-install:
		${MKDIR} ${DOCSDIR}
		${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
	.endif

makes a better bikeshed than:

	post-install:
	.if !defined(NOPORTDOCS)
		${MKDIR} ${DOCSDIR}
		${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
	.endif

Your variant keeps the empty post-install target in case of NOPORTDOCS.

But more importantly, please, do the same to gd2, which will eventually
replace gd...

	-mi



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110261649.f9QGnWa79416>