Date: Thu, 30 May 2002 11:00:17 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Alfred Perlstein <bright@mu.org> Subject: Re: cvs commit: src/contrib/gcc/config/i386 i386.h Message-ID: <XFMail.20020530110017.jhb@FreeBSD.org> In-Reply-To: <20020529234552.A62266@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30-May-2002 David O'Brien wrote: > On Wed, May 29, 2002 at 11:39:43PM -0700, Alfred Perlstein wrote: >> Also I don't see the point of being so damn vague with your commits >> to the source tree. > > I believe a commit message should tell the why, not the way, the diff > gives that. You can always follow up with an e-mail reply to explain what the practical implications are, something like "This turns off the i386 #define, you should only be using __i386__." or something for us ignorant masses who don't know what the log message means. :) I think that is all Alfred is asking for here. >> You do want help right? > > I (and the other committer that prompted me to desire this change) would > like the world not to do "#ifdef i386". Any slothing you can give to > make this possible is appreciated. > "find . -type f | xargs egrep 'def.*i386' | grep -v __i386__" didn't show > anything for me. Alfred has been running around fixing these yesterday and last night so it seems he is helping, no need to jump on his case. I think his point is more that he would appreciate if you had follow up replies or something that helped explain what the changes were doing in a practical sense to help other folks start to grok gcc so they can help take over maintaining it. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020530110017.jhb>