Date: Thu, 17 Nov 2005 13:31:08 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Edwin Groothuis <edwin@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/quake2lnx Makefile distinfo pkg-message pkg-plist ports/games/quake2lnx/files extra-patch-src_rogue_g__local.h extra-patch-src_rogue_q__shared.c extra-patch-src_xatrix_q__shared.c patch-Makefile patch-src::game::g_phys.c patch-src::linux::gl_glx.c patch-src::linux::rw_in_svgalib.c ... Message-ID: <20051117133108.GA29488@FreeBSD.org> In-Reply-To: <200511171051.jAHApSWX074582@repoman.freebsd.org> References: <200511171051.jAHApSWX074582@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 17, 2005 at 10:51:28AM +0000, Edwin Groothuis wrote: > [UPDATE] games/quake2lnx: integrate with "quake2-data" > > Changes: > * Integrate with "quake2-data". > * Add OPTIONS (21). > * Clean-up (sort knobs alphabetically, etc.). > * Automatically extract Rogue and Xatrix mission packs. > * Remove ARCH from library names (gamei386.so -> game.so). > Also increases portability (the library name was manually > defined between #ifdefs checking the architecture, and a > #error at the end). > * Change patch names (using "_" instead of "::"), and also some patches. I was under impression that we do not do this for patches already there, this convention typically should be only applied to new patch files. > > PR: ports/87181 > Submitted by: Alejandro Pulver <alejandro@varnet.biz> > Approved by: maintainer timeout Edwin, I wish I could say "thanks" for work you've done, but I would appreciate private confirmation mail even in case of "maintainer timeout". This is a complicated port, and such a change is potentially harmful due to its massiveness. Commits like this should probably be done per-piece fashion, otherwise it's really hard to check if nothing got broken. Not to mention that I actually disagree on the number of changes suggested in the PR (and committed by you). I'm not asking for a backout, in fact I realize how annoying it can be when PR hangs in "open" state for a month(s), and I would have probably needed to change PR state to something like "working on it, please be patient", however, I must say I got somewhat frustrated to have to fix all those things that I don't like WRT this commit. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051117133108.GA29488>