Date: Fri, 24 Jan 2003 13:50:54 +0100
From: Ulrich Spoerlein <q@uni.de>
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/47406: [Patch] Remove {PERL} from ports@'s ports
Message-ID: <20030124135054.76dbb045.q@uni.de>
In-Reply-To: <200301232330.h0NNU7EI005549@freefall.freebsd.org>
References: <200301232330.h0NNU7EI005549@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2003/01/23-15:30:07 Simon 'corecode' Schubert wrote:
> > diff -urN /usr/ports/x11/xcolorsel/Makefile xcolorsel/Makefile
> [...]
> > -WRKSRC= $(WRKDIR)/xcolorsel
> > +WRKSRC= ${WRKDIR}/xcolorsel
>
> woot?
() -> {}
Makes portlint happy.
> [...]
> > + @${REINPLACE_CMD} -e 's|app2head|./app2head|g' \
> > + -e 's|XawClientLibs|-lXaw3d \$$\(XMULIBONLY\) \$$\(XTOOLLIB\)
> > \$$\(XPMLIB) \$$\(XLIB\)|g' ${WRKSRC}/Imakefile
>
> you don't need to escape parentheses and $ in this context:
> -e 's|XawClientLibs|-lXaw3d $$(XMULIBONLY) $$(XTOOLLIB) $$(XPMLIB)
> $$(XLIB)|g' ${WRKSRC}/Imakefile
Sorry, just after sending this PR I read another post (from you?) about
sed's regex format, the -E switch and stuff. It's just that I "learned"
regex with Perl, so my Understanding of regexes is very perl-specific :(
> > diff -urN /usr/ports/deskutils/gnofin/Makefile gnofin/Makefile
> [...]
> > + ${REINPLACE_CMD} -E -e 's|-lpthread|${PTHREAD_LIBS}|g' \
> > + -e 's|DATADIRNAME=lib|DATADIRNAME=share|g' \
> > + -e 's|USE_INCLUDED_LIBINTL=yes|#USE_INCLUDED_LIBINTL=yes|g' \
> > + -e 's|\$$\(top_builddir\)/intl/libintl.a|-lintl|g'
> > ${WRKSRC}/configure
>
> what for -E ?
> either this way or without -E and without escaping the parentheses
> (looks better to me)
Yes of course, see explanation above.
> > diff -urN /usr/ports/security/fwbuilder/Makefile fwbuilder/Makefile
> [...]
> > + @${REINPLACE_CMD} -e 's/lc_r/pthread/' ${WRKSRC}/configure ;\
>
> use ${PTHREAD_LIBS}?
*sigh*...
> [...]
> > + @${REINPLACE_CMD} -e 's|^CFLAGS\s+=\s+-Wall\s+-g|CFLAGS = \@CFLAGS@
> > -Wall|' ${WRKSRC}/src/$i
>
> did you test this? sed doesn't know \s, just [[:space:]]
> you don't need to escape @ in sed
I hope sed understands [[:space:]]+ ?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030124135054.76dbb045.q>