Date: Thu, 4 Jul 2013 10:30:01 GMT From: Andrea Venturoli <ml@netfence.it> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/180168: [maintainer update] net/Sockets 2.3.9.9 Message-ID: <201307041030.r64AU1MZ024888@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/180168; it has been noted by GNATS.
From: Andrea Venturoli <ml@netfence.it>
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/180168: [maintainer update] net/Sockets 2.3.9.9
Date: Thu, 04 Jul 2013 12:21:37 +0200
On 07/04/13 11:47, Raphael Kubo da Costa wrote:
> Thank you. I've got a few additional comments after looking at the
> port's Makefile:
Thanks to you and please forgive my inexperience.
> o Instead of the BUILD_DEPENDS line you added, you can use
> USE_GNOME=libxml2:build instead.
Fine for me; I didn't know about this. Do you want me to send another patch?
> o libxml2 does not seem to be a build-dependency, but rather a generic
> library dependency (ie. LIB_DEPENDS). The pkg-config files generated
> by the port depend on it, for example.
Hmm...
I checked the port's own Makefile and it does not link against it.
Also, I'm developing a project which uses this library and I don't link
against libxml2 either.
However, feel free to put it as a library dependency if you think it
should be like this. Or I can send another patch if you confirm.
> o There's a section in the Makefile that says
>
> #Not needed without execinfo or xml
> #CFLAGS+= -I${LOCALBASE}/include
> #LDFLAGS+= -L${LOCALBASE}/lib
>
> Now that xml support has been added, do you need to uncomment out
> those lines?
I don't think so... this might be remnants of a very old version.
libxml2 requires "-I${LOCALBASE}/include/libxml2
-I${LOCALBASE}/include", but that is achieved by uncommenting the
following line in the port's Makefile:
CFLAGS += `xml2-config --cflags`
This is done through "patch/files-Makefile".
If changing CFLAGS in our Makefile is considered to be more elegant, the
above lines must still be altered (patch/files-Makfile won't go away,
though).
I tested against 8.3 and 9.1 and it compiles fine. Did you find some
problem on another platform?
bye & Thanks
av.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307041030.r64AU1MZ024888>