Date: Wed, 21 Jan 2015 00:11:37 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Hans Petter Selasky <hps@selasky.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <20150120211137.GY15484@FreeBSD.org> In-Reply-To: <20150120075126.GA42409@kib.kiev.ua> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <CAJ-Vmok0GXZoojyi=jE=b5D-d338APztaf3Pw0_AAQ-173XSWw@mail.gmail.com> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 20, 2015 at 09:51:26AM +0200, Konstantin Belousov wrote:
K> > Like stated in the manual page, callout_reset_curcpu/on() does not work
K> > with MPSAFE callouts any more!
K> I.e. you 'fixed' some undeterminate bugs in callout migration by not
K> doing migration at all anymore.
K>
K> >
K> > You need to use callout_init_{mtx,rm,rw} and remove the custom locking
K> > inside the callback in the TCP stack to get it working like before!
K>
K> No, you need to do this, if you think that whole callout KPI must be
K> rototiled. It is up to the person who modifies the KPI, to ensure that
K> existing code is not broken.
K>
K> As I understand, currently we are back to the one-cpu callouts.
K> Do other people consider this situation acceptable ?
I think this isn't acceptable. The commit to a complex subsystem
lacked a review from persons involved in the system before. The
commit to subsystem broke consumers of the subsystem and this
was even done not accidentially, but due to Hans not caring about
it.
As for me this is enough to request a backout, and let the change
back in only after proper review.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150120211137.GY15484>