Date: Fri, 6 Sep 2013 19:47:46 +0100 (BST) From: Ben Morrow <ben@morrow.me.uk> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/181896: editors/vim: gvim requires pkgconf to build Message-ID: <20130906184747.03F08D6D6@anubis.morrow.me.uk> Resent-Message-ID: <201309061850.r86Io0AK064240@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 181896
>Category: ports
>Synopsis: editors/vim: gvim requires pkgconf to build
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 06 18:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Ben Morrow
>Release: FreeBSD 9.1-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD anubis.morrow.me.uk 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #1 r+47614d7: Tue Jun 25 08:08:41 BST 2013 mauzo@anubis:/usr/obj/usr/src/sys/ANUBIS amd64
>Description:
I'm not sure what has caused the recent spate of ports needing explicit
pkgconf dependencies, but gvim appears to have been missed. Without
pkgconf installed configure fails to find the GTK libraries, and vim
builds without a GUI.
>How-To-Repeat:
Build editors/vim with the GTK GUI selected, but without pkgconf
installed (say, as part of a 'poudriere bulk' build). configure will
fail to find the installed GTK libraries, and the GUI will not be built.
>Fix:
Patch included below. This also removes the --with-gtk-prefix option,
since configure was complaining about it.
I am assuming that the Gnome GUI needs pkgconf, just as the GTK one
does.
diff --git a/editors/vim/Makefile b/editors/vim/Makefile
index bc6ccea..b68f158 100644
--- a/editors/vim/Makefile
+++ b/editors/vim/Makefile
@@ -146,13 +146,15 @@ USE_XORG+= xaw
. endif
. if ${PORT_OPTIONS:MGTK2}
+USES+= pkgconfig
USE_GNOME= gtk20
-CONF_OPT_GUI="--enable-gui=gtk2 --with-gtk-prefix=${LOCALBASE}"
+CONF_OPT_GUI="--enable-gui=gtk2"
MAKE_ARGS+= X_LIBS="$(X_LIBS) -lXt"
USE_XORG+= xt
. endif
. if ${PORT_OPTIONS:MGNOME}
+USES+= pkgconfig
USE_GNOME= libgnomeui
PKGNAMESUFFIX= -gnome2
CONF_OPT_GUI="--enable-gui=gnome2"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130906184747.03F08D6D6>