Date: Mon, 3 Mar 2014 10:22:45 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <jmmv@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: [PATCH] Integrate pjdfstest into the build Message-ID: <CAGHfRMB4eOBFvyCk517hLNwJK3K9nfWzjCN6dwF5W4cOkOVeXw@mail.gmail.com> In-Reply-To: <CAFY7cWCme4QTbo86uQhJ_DFLb9Z6dfWaj_%2Bs9m-tWFw35Vx%2BAQ@mail.gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ@mail.gmail.com> <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> <CAFY7cWCme4QTbo86uQhJ_DFLb9Z6dfWaj_%2Bs9m-tWFw35Vx%2BAQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 2, 2014 at 3:00 PM, Julio Merino <jmmv@freebsd.org> wrote: > On Sun, Mar 2, 2014 at 5:54 PM, Garrett Cooper <yanegomi@gmail.com> wrote= : >>> * The test files should move from tools/regression/pjdfstest/ into the >>> new location under tests/sys/ and be renamed to follow the conventions >>> under src/test (e.g. xx.t -> xx_test). >> >> Please talk to Pawel about this. These tests have been developed and are= maintained (to some degree) outside FreeBSD: https://github.com/pjd/pjdfst= est . I'd rather treat this as an integration of the 3rd party package, not= a refactor. If you want me to install the tests like _test though, I'd be = more than happy to do that. > > Ah great; that's what I suspected given the mentions of other OSes in the= code! > > Then I believe this should really live under contrib/pjdfstest. Any > reason it's not there? If it's external, then yes, we should keep the > layout of the upstream sources without performing any renames (unless > Pawel wants to do them). I think it should be, but I don't own pjdfstest ;).. (largely for jmmv's benefit) Ultimately if pjd went this route, pjdfstest needs to be put in the vendor repo, reimported into FreeBSD under contrib, and then linked into the tree appropriately. Thank you :), -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMB4eOBFvyCk517hLNwJK3K9nfWzjCN6dwF5W4cOkOVeXw>