Date: Wed, 5 Oct 2011 21:21:39 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: "Jayachandran C." <c.jayachandran@gmail.com> Cc: mips@freebsd.org Subject: Re: Mips syscall entry point Message-ID: <20111005182139.GG1511@deviant.kiev.zoral.com.ua> In-Reply-To: <CA%2B7sy7D1Jh_gq6LXd-guVqAGMfPauB4FNpPtqT58Bv5N4=91ZQ@mail.gmail.com> References: <20111004211144.GW1511@deviant.kiev.zoral.com.ua> <20111004215218.GY1511@deviant.kiev.zoral.com.ua> <CA%2B7sy7BfMgyw5E%2BP6QzcH02Fn4eMNiD%2B__d0Ji8Fjq9rXBg5Lg@mail.gmail.com> <CA%2B7sy7CKYLL7%2BMjB242=XkFP=S728m1=77%2BBqEra9KcmJ0tBKg@mail.gmail.com> <20111005144605.GC1511@deviant.kiev.zoral.com.ua> <CA%2B7sy7D1Jh_gq6LXd-guVqAGMfPauB4FNpPtqT58Bv5N4=91ZQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--86Kqgbv7jwc0ijsN Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 05, 2011 at 10:50:29PM +0530, Jayachandran C. wrote: > 2011/10/5 Kostik Belousov <kostikbel@gmail.com>: > > On Wed, Oct 05, 2011 at 05:56:10PM +0530, Jayachandran C. wrote: > >> On Wed, Oct 5, 2011 at 5:05 PM, Jayachandran C. > >> <c.jayachandran@gmail.com> wrote: > >> > On Wed, Oct 5, 2011 at 3:22 AM, Kostik Belousov <kostikbel@gmail.com= > wrote: > >> >> On Wed, Oct 05, 2011 at 12:11:44AM +0300, Kostik Belousov wrote: > >> >>> Hi, > >> >>> below is the patch, test-compiled for XLP64 only, which converts t= he > >> >>> only remaining architecture MIPS to the new syscall entry sequence. > >> >>> The advantage of the conversion is sharing most of the code with a= ll > >> >>> other architectures and avoiding duplication. Also, the implementa= tion > >> >>> automatically feels the missed features for the MIPS, see the BUGS > >> >> s/feels/fills/, sorry > >> >>> section in the ptrace(2). > >> >> For the same reason, capsicum shall not work on MIPS. > >> >> > >> >>> > >> >>> I am asking for you help to debug and test the patch. Please keep = me > >> >>> on Cc:, I am not on the list. > >> >>> > >> >>> Thank you. > >> >>> > >> >>> diff --git a/sys/mips/include/proc.h b/sys/mips/include/proc.h > >> >>> index 11a1f8e..4c0b0b6 100644 > >> [...] > >> > > >> > This gives me a crash when I test it on XLR (32bit compile). =9AThe > >> > crash does not look obvious - I am looking at it, hope to resolve th= is > >> > soon. > >> > >> Actually it is fairly obvious :) =9Athe elf*_machdep.c has to be updat= ed > >> for using the cpu_fetch_syscall_args. With that change it comes up on > >> 32 bit - will do a few more tests on 64 bit to see how that goes. > >> > >> The other minor issue I saw was the locr0 usage in trap(), in call to > >> trapdebug_enter, =9Ait is fine now since =9ATRAP_DEBUG is not defined. > > > > Thank you very much. Your fix is applied, and I tried to cover both > > locr0 and code usage. > > > > Will wait for your testing. >=20 > This works for me, tried on o32/n32/n64 on XLR. Thanks for fixing this up > . > JC. Thank you again. Should I consider this as an approval to commit the patch ? (I will make universe it before committing anyway). --86Kqgbv7jwc0ijsN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6MoDMACgkQC3+MBN1Mb4iF3gCggjZn+OQ3bEHziYRpA6hZXQn8 Bf0AniGhcuh/WqfsArBLoPxM7+vYWsJr =iEEW -----END PGP SIGNATURE----- --86Kqgbv7jwc0ijsN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111005182139.GG1511>