Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 May 2013 22:16:20 +0200
From:      Eitan Adler <eadler@freebsd.org>
To:        Mikhail Teterin <mi@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r318714 - in head/security/sudosh3: . files
Message-ID:  <CAF6rxgkshUJhsfNbsxHWymF5MBoQ3CkoaDncJ%2BeQB6uo0z8O6A@mail.gmail.com>
In-Reply-To: <201305211629.r4LGTJn3060919@svn.freebsd.org>
References:  <201305211629.r4LGTJn3060919@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 21 May 2013 18:29, Mikhail Teterin <mi@freebsd.org> wrote:
> Author: mi
> Date: Tue May 21 16:29:19 2013
> New Revision: 318714
> URL: http://svnweb.freebsd.org/changeset/ports/318714
>
> Log:
>   Refactor the replay code to fix the reported vulnerability -- simply use mmap()
>   instead of a buffer.

Is there a new version of this program upstream?

>   While here, fix warnings -- well enough for gcc48 to be happy with ``-Wall -W''.

Changes like this are annoying because they make it harder to see what
actually is required to be reported upstream.  Is there a reason
warnings can't be disabled?
IMHO fixing "argument unused" errors in ports code is not very important.


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkshUJhsfNbsxHWymF5MBoQ3CkoaDncJ%2BeQB6uo0z8O6A>