Date: Thu, 25 Sep 2014 20:31:03 +0000
From: bugzilla-noreply@freebsd.org
To: perl@FreeBSD.org
Subject: maintainer-approval requested: [Bug 193934] Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)" : [Attachment 147679] Fix bogus *** Error 1 (ignored) and reinstate error check for ${FIND}/${SED}.
Message-ID: <bug-193934-14331-ttq3QitYcC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193934-14331@https.bugs.freebsd.org/bugzilla/>
References: <bug-193934-14331@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthias Andree <mandree@FreeBSD.org> has asked perl@FreeBSD.org for maintainer-approval: Bug 193934: Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)" https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193934 Attachment 147679: Fix bogus *** Error 1 (ignored) and reinstate error check for ${FIND}/${SED}. https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147679&action=edit ------- Additional Comments from Matthias Andree <mandree@FreeBSD.org> ports/Mk/Uses/perl5.mk abuses shell list sequencing with "&&" operators, and this causes bogus errors in make on ports that run fix-packlist without the SITE_PERL_REL/PERL_ARCH/auto dir installed, for instance, marino's upcoming net-mgmt/netdisco port. The syntax goes along these lines: -@a && b But if "a" failing isn't an error, then instead we should write: if a ; then b ; fi This will also ensure that errors from b are NOT ignored (they are now). Proposed patch attached. Please check if this needs an -exp run.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193934-14331-ttq3QitYcC>