Date: Thu, 26 Dec 2013 12:13:17 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common Message-ID: <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> In-Reply-To: <CAJ-Vmo=FufoALvqW-y9iXk%2BfHXDzNcd1riXX5%2Bg_1kG-Kus1=w@mail.gmail.com> References: <201312252245.rBPMjX5J046556@svn.freebsd.org> <CAJ-Vmo=FufoALvqW-y9iXk%2BfHXDzNcd1riXX5%2Bg_1kG-Kus1=w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=iso-8859-1 On 26 Dec 2013, at 02:51, Adrian Chadd <adrian@freebsd.org> wrote: > I'd prefer you didn't remove unused code in drivers like this. If you > must, #if 0 them out. I don't mind either way, but some other people are very much opposed to littering code with #if 0'd sections. So, how do to determine what is right in each situation? :-) > Future people hacking on the driver may find it nice to have as much > code in there which talks to the hardware. It may not be currently > called, but it's at least there. In this particular case, the code has never been used, even when the file was originally committed, so I would say the chances of it ever being used again are near zero. (And even after deletion, the old versions are available in our repository.) For more "active" drivers, I will certainly just use #if, or simply turn off the -Wunused-function warning. And hope the code gets used eventually. :-) -Dimitry --Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlK8D1UACgkQsF6jCi4glqM0HwCeNoNZZ832zpI7e6O/LZCC65ML 97QAoIfvOAmGieRcxo8K2ZMdvG/6n6gQ =bgxR -----END PGP SIGNATURE----- --Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76C5CECF-1A27-4245-B5D1-335C46B253E7>