Date: Sun, 28 Oct 2001 17:41:32 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/lastlogin lastlogin.c Message-ID: <200110290141.f9T1fW622368@apollo.backplane.com> References: <200110290040.f9T0e5N27673@freefall.freebsd.org> <20011029035153.A693@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:On Sun, Oct 28, 2001 at 16:40:05 -0800, Matt Dillon wrote:
:> dillon 2001/10/28 16:40:05 PST
:>
:> Modified files:
:> usr.sbin/lastlogin lastlogin.c
:> Log:
:> Fix ctime(&int) due to change to lastlog->ll_time
:
:I am not sure that you are at the right way. Lots of 3rd party programs
:from ports do the same things you try to fix. I understand your intention
:to fix time type for protocols, but fixing them for utmp or lastlog files
:gives more pain than adds value. What is wrong to let lastlog/utmp stay in
:machine-dependend format?
:
:--
:Andrey A. Chernov
sizeof(time_t) does not necessarily equal sizeof(int)... even if were
only to adopt the 64 bit platform 64 bit time_t's these programs would
break because ll_time is an int.
I didn't make the ll_time change, but I'm not against it either.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110290141.f9T1fW622368>