Date: Thu, 6 Oct 2011 13:00:15 +0530 From: "Jayachandran C." <c.jayachandran@gmail.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: mips@freebsd.org Subject: Re: Mips syscall entry point Message-ID: <CA%2B7sy7CqVsC-JWT9OyiJMhez9OqwqW8MTK96q34AYN%2B0DL=OSQ@mail.gmail.com> In-Reply-To: <20111005182139.GG1511@deviant.kiev.zoral.com.ua> References: <20111004211144.GW1511@deviant.kiev.zoral.com.ua> <20111004215218.GY1511@deviant.kiev.zoral.com.ua> <CA%2B7sy7BfMgyw5E%2BP6QzcH02Fn4eMNiD%2B__d0Ji8Fjq9rXBg5Lg@mail.gmail.com> <CA%2B7sy7CKYLL7%2BMjB242=XkFP=S728m1=77%2BBqEra9KcmJ0tBKg@mail.gmail.com> <20111005144605.GC1511@deviant.kiev.zoral.com.ua> <CA%2B7sy7D1Jh_gq6LXd-guVqAGMfPauB4FNpPtqT58Bv5N4=91ZQ@mail.gmail.com> <20111005182139.GG1511@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/10/5 Kostik Belousov <kostikbel@gmail.com>: > On Wed, Oct 05, 2011 at 10:50:29PM +0530, Jayachandran C. wrote: >> 2011/10/5 Kostik Belousov <kostikbel@gmail.com>: >> > On Wed, Oct 05, 2011 at 05:56:10PM +0530, Jayachandran C. wrote: >> >> On Wed, Oct 5, 2011 at 5:05 PM, Jayachandran C. >> >> <c.jayachandran@gmail.com> wrote: >> >> > On Wed, Oct 5, 2011 at 3:22 AM, Kostik Belousov <kostikbel@gmail.co= m> wrote: >> >> >> On Wed, Oct 05, 2011 at 12:11:44AM +0300, Kostik Belousov wrote: >> >> >>> Hi, >> >> >>> below is the patch, test-compiled for XLP64 only, which converts = the >> >> >>> only remaining architecture MIPS to the new syscall entry sequenc= e. >> >> >>> The advantage of the conversion is sharing most of the code with = all >> >> >>> other architectures and avoiding duplication. Also, the implement= ation >> >> >>> automatically feels the missed features for the MIPS, see the BUG= S >> >> >> s/feels/fills/, sorry >> >> >>> section in the ptrace(2). >> >> >> For the same reason, capsicum shall not work on MIPS. >> >> >> >> >> >>> >> >> >>> I am asking for you help to debug and test the patch. Please keep= me >> >> >>> on Cc:, I am not on the list. >> >> >>> >> >> >>> Thank you. >> >> >>> >> >> >>> diff --git a/sys/mips/include/proc.h b/sys/mips/include/proc.h >> >> >>> index 11a1f8e..4c0b0b6 100644 >> >> [...] >> >> > >> >> > This gives me a crash when I test it on XLR (32bit compile). =A0The >> >> > crash does not look obvious - I am looking at it, hope to resolve t= his >> >> > soon. >> >> >> >> Actually it is fairly obvious :) =A0the elf*_machdep.c has to be upda= ted >> >> for using the cpu_fetch_syscall_args. With that change it comes up on >> >> 32 bit - will do a few more tests on 64 bit to see how that goes. >> >> >> >> The other minor issue I saw was the locr0 usage in trap(), in call to >> >> trapdebug_enter, =A0it is fine now since =A0TRAP_DEBUG is not defined= . >> > >> > Thank you very much. Your fix is applied, and I tried to cover both >> > locr0 and code usage. >> > >> > Will wait for your testing. >> >> This works for me, tried on o32/n32/n64 on XLR. =A0Thanks for fixing thi= s up >> . >> JC. > > Thank you again. > > Should I consider this as an approval to commit the patch ? > (I will make universe it before committing anyway). Since this is the right way of doing the syscall, my recommendation would be to check in. If there are any issues or comments later, I will hopefully be able to take care of them. JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B7sy7CqVsC-JWT9OyiJMhez9OqwqW8MTK96q34AYN%2B0DL=OSQ>