Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Apr 2008 16:23:09 GMT
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 139418 for review
Message-ID:  <200804051623.m35GN9va033294@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=139418

Change 139418 by sam@sam_ebb on 2008/04/05 16:22:21

	correct locking on detach

Affected files ...

.. //depot/projects/vap/sys/dev/ral/rt2560.c#25 edit
.. //depot/projects/vap/sys/dev/ral/rt2661.c#22 edit

Differences ...

==== //depot/projects/vap/sys/dev/ral/rt2560.c#25 (text) ====

@@ -360,7 +360,6 @@
 	struct ieee80211com *ic = ifp->if_l2com;
 	
 	rt2560_stop(sc);
-	RAL_LOCK(sc);
 
 	bpfdetach(ifp);
 	ieee80211_ifdetach(ic);

==== //depot/projects/vap/sys/dev/ral/rt2661.c#22 (text) ====

@@ -358,6 +358,7 @@
 	RAL_LOCK(sc);
 	rt2661_stop_locked(sc);
 	callout_stop(&sc->watchdog_ch);
+	RAL_UNLOCK(sc);
 
 	bpfdetach(ifp);
 	ieee80211_ifdetach(ic);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200804051623.m35GN9va033294>