Date: Wed, 30 Oct 1996 21:39:59 +0100 (MET) From: Guido van Rooij <guido@gvr.win.tue.nl> To: john@starfire.mn.org Cc: hackers@FreeBSD.ORG Subject: Re: rlogind user name restrictions Message-ID: <199610302040.VAA09887@gvr.win.tue.nl> In-Reply-To: <199610302035.OAA03828@starfire.mn.org> from "john@starfire.mn.org" at "Oct 30, 96 02:35:19 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
john@starfire.mn.org wrote:
>
> > --- /usr/src/libexec/rlogind/rlogind.c Sun Jun 23 15:07:44 1996
> > +++ /tmp/rlogind.c Wed Oct 30 20:55:23 1996
> > @@ -293,7 +293,7 @@
> > if (f > 2) /* f should always be 0, but... */
> > (void) close(f);
> > setup_term(0);
> > - if (strchr(lusername, '-')) {
> > + if (lusername == '-') {
> ^^^^^^^^^
> Shouldn't this be "*lusername" or "lusername[0]"?????????
Of course that should be *lusername.
That's the problem when you havent setup cvsup and you do things by
head ;-()
>
> Even doing this, has it been checked that there are no throw-away
> characters that login might skip over that would make the corrected
> test ineffectual? I'm not that totally familiar with the internal
> operation of "getopt" that I could speak authoritatively to this
> issue, which is why I didn't submit my diffs in the first place.
> That was what I meant by "BAD THINGS".
no problems there.
-Guido
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610302040.VAA09887>