Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jan 2014 22:33:21 -0800
From:      hiren panchasara <hiren@FreeBSD.org>
To:        Luigi Rizzo <rizzo@iet.unipi.it>
Cc:        svn-src-head <svn-src-head@freebsd.org>, Luigi Rizzo <luigi@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>
Subject:   Re: svn commit: r260700 - in head: sys/dev/netmap tools/tools/netmap
Message-ID:  <CALCpEUFTK8ERX5UsReBp=1Axf4mDuWUTTVpNChKT0VLV%2BGDQng@mail.gmail.com>
In-Reply-To: <20140117044254.GB56239@onelab2.iet.unipi.it>
References:  <201401160020.s0G0KgwY004039@svn.freebsd.org> <CALCpEUFGCb_%2Bw438BaWMGZKH1WwsTL3njLEcv2TPfL0TZ8NFkA@mail.gmail.com> <20140117044254.GB56239@onelab2.iet.unipi.it>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 16, 2014 at 8:42 PM, Luigi Rizzo <rizzo@iet.unipi.it> wrote:
> On Thu, Jan 16, 2014 at 12:46:10PM -0800, hiren panchasara wrote:
>> On Wed, Jan 15, 2014 at 4:20 PM, Luigi Rizzo <luigi@freebsd.org> wrote:
>> > Author: luigi
>> > Date: Thu Jan 16 00:20:42 2014
>> > New Revision: 260700
>> > URL: http://svnweb.freebsd.org/changeset/base/260700
>> >
>> > Log:
>> >   netmap_user.h:
>> >      add separate rx/tx ring indexes
>> >      add ring specifier in nm_open device name
>> >
>> >   netmap.c, netmap_vale.c
>> >      more consistent errno numbers
>> >
>> >   netmap_generic.c
>> >      correctly handle failure in registering interfaces.
>> >
>> >   tools/tools/netmap/
>> >      massive cleanup of the example programs
>> >      (a lot of common code is now in netmap_user.h.)
>> >
>> >   nm_util.[ch] are going away soon.
>> >   pcap.c will also go when i commit the native netmap support for libpcap.
>> >
>> > Modified:
>> >   head/sys/dev/netmap/netmap.c
>> >   head/sys/dev/netmap/netmap_generic.c
>> >   head/sys/dev/netmap/netmap_vale.c
>> >   head/tools/tools/netmap/Makefile
>> >   head/tools/tools/netmap/bridge.c
>> >   head/tools/tools/netmap/nm_util.c
>> >   head/tools/tools/netmap/nm_util.h
>> >   head/tools/tools/netmap/pcap.c
>> >   head/tools/tools/netmap/pkt-gen.c
>> >   head/tools/tools/netmap/vale-ctl.c
>> >
>>
>> Hi Luigi,
>>
>> Doing make in tools/tools/netmap gives me a bunch of errors because
>> "struct nm_desc_t" doesn't have members like if_flags, if_reqcap and
>> if_curcap. It seems those members were coming from struct my_ring
>> which is no more there.
>
> sorry my bad, i forgot to include sys/net/netmap_user.h in the commit.
> Fixed in rev 260803

Thank you,
Hiren



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALCpEUFTK8ERX5UsReBp=1Axf4mDuWUTTVpNChKT0VLV%2BGDQng>